-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: renew SSL certificate in Pulumi #2380
Merged
jemrobinson
merged 10 commits into
alan-turing-institute:release-v5.3.1
from
jemrobinson:2361-renew-ssl-cert
Jan 27, 2025
Merged
Hotfix: renew SSL certificate in Pulumi #2380
jemrobinson
merged 10 commits into
alan-turing-institute:release-v5.3.1
from
jemrobinson:2361-renew-ssl-cert
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er than 30 days of validity remaining
…catch the case where a non-existent certificate is being purged
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
JimMadge
reviewed
Jan 27, 2025
Co-authored-by: Jim Madge <[email protected]>
JimMadge
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I changed the "Closes" because I think we still want a more robust solution here.
jemrobinson
merged commit Jan 27, 2025
e64afdb
into
alan-turing-institute:release-v5.3.1
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.🚦 Depends on
n/a
Adds a check for SSL certificate expiry date and marks the resource as needing an update if we are within 30 days of expiry.
🌂 Related issues
Contributes to #2361
🔬 Tests
Tested on a fresh SRE deployment