Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: renew SSL certificate in Pulumi #2380

Merged

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Jan 27, 2025

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Adds a check for SSL certificate expiry date and marks the resource as needing an update if we are within 30 days of expiry.

🌂 Related issues

Contributes to #2361

🔬 Tests

Tested on a fresh SRE deployment

@jemrobinson jemrobinson requested review from a team as code owners January 27, 2025 12:33
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/external/api
  azure_sdk.py 831, 1100
  data_safe_haven/infrastructure/components/dynamic
  ssl_certificate.py 66, 101, 124-126, 159, 174-179, 188-198
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I changed the "Closes" because I think we still want a more robust solution here.

@jemrobinson jemrobinson merged commit e64afdb into alan-turing-institute:release-v5.3.1 Jan 27, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants