Skip to content

Commit

Permalink
Update API
Browse files Browse the repository at this point in the history
  • Loading branch information
al8n committed Apr 15, 2024
1 parent ce6c1d4 commit 5bb9cff
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion core/src/key_manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ where
ch: Receiver<NodeResponse<T::Id, <T::Resolver as AddressResolver>::ResolvedAddress>>,
) -> KeyResponse<T::Id> {
let mut resp = KeyResponse {
num_nodes: self.serf.get().unwrap().num_nodes().await,
num_nodes: self.serf.get().unwrap().num_members().await,
messages: HashMap::new(),
num_resp: 0,
num_err: 0,
Expand Down
4 changes: 2 additions & 2 deletions core/src/serf/api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,13 @@ where
/// Returns the number of nodes in the serf cluster, regardless of
/// their health or status.
#[inline]
pub async fn num_nodes(&self) -> usize {
pub async fn num_members(&self) -> usize {
self.inner.members.read().await.states.len()
}

/// Returns the key manager for the current serf instance
#[cfg(feature = "encryption")]
#[cfg_attr(docsrs, doc(cfg(feature = "encryption")))]
#[inline]
pub fn key_manager(&self) -> &crate::key_manager::KeyManager<T, D> {
&self.inner.key_manager
Expand Down Expand Up @@ -628,7 +629,6 @@ where
}

/// Returns the underlying [`Memberlist`] instance
#[allow(private_interfaces)]
#[inline]
pub fn memberlist(&self) -> &Memberlist<T, SerfDelegate<T, D>> {
&self.inner.memberlist
Expand Down
2 changes: 1 addition & 1 deletion core/src/serf/base/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ where
<T::Runtime as RuntimeLite>::sleep(Duration::from_millis(25)).await;
let mut conds = Vec::with_capacity(serfs.len());
for (idx, s) in serfs.iter().enumerate() {
let n = s.num_nodes().await;
let n = s.num_members().await;
if n == desired_nodes {
conds.push(true);
continue;
Expand Down
2 changes: 1 addition & 1 deletion core/src/serf/base/tests/serf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ where
.await
.unwrap();

assert_eq!(s1.num_nodes().await, 1);
assert_eq!(s1.num_members().await, 1);

let serfs = [s1, s2];
wait_until_num_nodes(1, &serfs).await;
Expand Down
2 changes: 1 addition & 1 deletion core/src/serf/base/tests/serf/leave.rs
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ pub async fn serf_leave_snapshot_recovery<T, F>(
let mut cond2 = false;
loop {
if !cond1 {
let num = serfs[1].num_nodes().await;
let num = serfs[1].num_members().await;
if num == 1 {
cond1 = true;
}
Expand Down
8 changes: 4 additions & 4 deletions core/src/serf/base/tests/serf/reconnect.rs
Original file line number Diff line number Diff line change
Expand Up @@ -202,15 +202,15 @@ pub async fn serf_per_node_reconnect_timeout<T>(
let mut cond2 = false;
loop {
<T::Runtime as RuntimeLite>::sleep(Duration::from_millis(25)).await;
let n = s1.num_nodes().await;
let n = s1.num_members().await;
if n == 1 {
cond1 = true;
}
if start.elapsed() > Duration::from_secs(7) {
panic!("s1 got {} expected {}", n, 1);
}

let n = s2.num_nodes().await;
let n = s2.num_members().await;
if n == 1 {
cond2 = true;
}
Expand All @@ -233,15 +233,15 @@ pub async fn serf_per_node_reconnect_timeout<T>(
let mut cond2 = false;
loop {
<T::Runtime as RuntimeLite>::sleep(Duration::from_millis(25)).await;
let n = s1.num_nodes().await;
let n = s1.num_members().await;
if n == 2 {
cond1 = true;
}
if start.elapsed() > Duration::from_secs(7) {
panic!("s1 got {} expected {}", n, 2);
}

let n = s2.num_nodes().await;
let n = s2.num_members().await;
if n == 2 {
cond2 = true;
}
Expand Down

0 comments on commit 5bb9cff

Please sign in to comment.