Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP(ui): AnalysisRun logs #3674

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

Marvin9
Copy link
Contributor

@Marvin9 Marvin9 commented Mar 19, 2025

ui prototype for #3641

in Analysis run modal

Screenshot 2025-03-19 at 1 52 38 PM (2)

Deep link full page

Screenshot 2025-03-19 at 1 53 12 PM (2)

cc @jessesuen @kencochrane @krancour

Marvin9 and others added 6 commits March 18, 2025 18:44
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
Copy link

netlify bot commented Mar 19, 2025

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit cdcc61a
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67dbf3e83d4b6100085341e9
😎 Deploy Preview https://deploy-preview-3674.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 47.59358% with 196 lines in your changes missing coverage. Please review.

Project coverage is 21.91%. Comparing base (f2da591) to head (cdcc61a).

Files with missing lines Patch % Lines
internal/server/get_analysisrun_logs_v1alpha1.go 61.16% 111 Missing and 2 partials ⚠️
experiments/main.go 0.00% 33 Missing ⚠️
experiments/auth.go 0.00% 22 Missing ⚠️
...ice/v1alpha1/svcv1alpha1connect/service.connect.go 0.00% 18 Missing ⚠️
internal/server/config/config.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3674      +/-   ##
==========================================
+ Coverage   21.79%   21.91%   +0.11%     
==========================================
  Files         310      313       +3     
  Lines       64706    65167     +461     
==========================================
+ Hits        14105    14283     +178     
- Misses      49836    50117     +281     
- Partials      765      767       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Marvin9 Marvin9 added this to the v1.4.0 milestone Mar 19, 2025
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
Signed-off-by: Kent Rancourt <[email protected]>
@kencochrane
Copy link
Contributor

Looks good, we don't need "follow logs" though since these won't be live logs.

Marvin9 added 2 commits March 20, 2025 10:03
…ranch 'origin' into Marvin9/feat-analysisrun-logs-ui
Signed-off-by: Mayursinh Sarvaiya <[email protected]>
@blakestoddard
Copy link

Live tail would be a nice feature if you’re running a long-running integration test and want to know where it’s at in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants