Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support ConsecutiveSuccessLimit from Argo Rollouts 1.8.0 #3654

Merged
merged 3 commits into from
Mar 18, 2025
Merged

chore: support ConsecutiveSuccessLimit from Argo Rollouts 1.8.0 #3654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50648ff
chore(deps): update Argo Rollouts to 1.8.x
hiddeco Mar 14, 2025
cd7fa24
chore: add ConsecutiveSuccessLimit from upstream
hiddeco Mar 14, 2025
3473a3c
chore: run codegen
hiddeco Mar 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ SHELL ?= /bin/bash
EXTENDED_PATH ?= $(CURDIR)/hack/bin:$(PATH)

ARGO_CD_CHART_VERSION := 7.7.0
ARGO_ROLLOUTS_CHART_VERSION := 2.37.7
ARGO_ROLLOUTS_CHART_VERSION := 2.39.1
CERT_MANAGER_CHART_VERSION := 1.16.1

BUF_LINT_ERROR_FORMAT ?= text
Expand Down
21 changes: 11 additions & 10 deletions api/stubs/rollouts/v1alpha1/analysis_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,17 @@ func (d DurationString) Duration() (time.Duration, error) {
}

type Metric struct {
Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
Interval DurationString `json:"interval,omitempty" protobuf:"bytes,2,opt,name=interval,casttype=DurationString"`
InitialDelay DurationString `json:"initialDelay,omitempty" protobuf:"bytes,3,opt,name=initialDelay,casttype=DurationString"`
Count *intstrutil.IntOrString `json:"count,omitempty" protobuf:"bytes,4,opt,name=count"`
SuccessCondition string `json:"successCondition,omitempty" protobuf:"bytes,5,opt,name=successCondition"`
FailureCondition string `json:"failureCondition,omitempty" protobuf:"bytes,6,opt,name=failureCondition"`
FailureLimit *intstrutil.IntOrString `json:"failureLimit,omitempty" protobuf:"bytes,7,opt,name=failureLimit"`
InconclusiveLimit *intstrutil.IntOrString `json:"inconclusiveLimit,omitempty" protobuf:"bytes,8,opt,name=inconclusiveLimit"`
ConsecutiveErrorLimit *intstrutil.IntOrString `json:"consecutiveErrorLimit,omitempty" protobuf:"bytes,9,opt,name=consecutiveErrorLimit"`
Provider MetricProvider `json:"provider" protobuf:"bytes,10,opt,name=provider"`
Name string `json:"name" protobuf:"bytes,1,opt,name=name"`
Interval DurationString `json:"interval,omitempty" protobuf:"bytes,2,opt,name=interval,casttype=DurationString"`
InitialDelay DurationString `json:"initialDelay,omitempty" protobuf:"bytes,3,opt,name=initialDelay,casttype=DurationString"`
Count *intstrutil.IntOrString `json:"count,omitempty" protobuf:"bytes,4,opt,name=count"`
SuccessCondition string `json:"successCondition,omitempty" protobuf:"bytes,5,opt,name=successCondition"`
FailureCondition string `json:"failureCondition,omitempty" protobuf:"bytes,6,opt,name=failureCondition"`
FailureLimit *intstrutil.IntOrString `json:"failureLimit,omitempty" protobuf:"bytes,7,opt,name=failureLimit"`
InconclusiveLimit *intstrutil.IntOrString `json:"inconclusiveLimit,omitempty" protobuf:"bytes,8,opt,name=inconclusiveLimit"`
ConsecutiveErrorLimit *intstrutil.IntOrString `json:"consecutiveErrorLimit,omitempty" protobuf:"bytes,9,opt,name=consecutiveErrorLimit"`
Provider MetricProvider `json:"provider" protobuf:"bytes,10,opt,name=provider"`
ConsecutiveSuccessLimit *intstrutil.IntOrString `json:"consecutiveSuccessLimit,omitempty" protobuf:"bytes,11,opt,name=consecutiveSuccessLimit"`
}

type DryRun struct {
Expand Down
469 changes: 262 additions & 207 deletions api/stubs/rollouts/v1alpha1/generated.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions api/stubs/rollouts/v1alpha1/generated.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions api/stubs/rollouts/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion hack/quickstart/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -x

argo_cd_chart_version=7.7.0
argo_rollouts_chart_version=2.37.7
argo_rollouts_chart_version=2.39.1
cert_manager_chart_version=1.16.1

helm install cert-manager cert-manager \
Expand Down
2 changes: 1 addition & 1 deletion hack/quickstart/k3d.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -x

argo_cd_chart_version=7.7.0
argo_rollouts_chart_version=2.37.7
argo_rollouts_chart_version=2.39.1
cert_manager_chart_version=1.16.1

k3d cluster create kargo-quickstart \
Expand Down
2 changes: 1 addition & 1 deletion hack/quickstart/kind.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -x

argo_cd_chart_version=7.7.0
argo_rollouts_chart_version=2.37.7
argo_rollouts_chart_version=2.39.1
cert_manager_chart_version=1.16.1

kind create cluster \
Expand Down
7 changes: 6 additions & 1 deletion ui/src/gen/api/stubs/rollouts/v1alpha1/generated_pb.ts
View file
Open in desktop

Large diffs are not rendered by default.