-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add actor metadata to Promotion context #3592
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3592 +/- ##
==========================================
+ Coverage 52.82% 52.85% +0.02%
==========================================
Files 299 299
Lines 26892 26908 +16
==========================================
+ Hits 14206 14221 +15
- Misses 11924 11925 +1
Partials 762 762 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
logic as "Created By" column on the UI. Signed-off-by: Keith Zeto <[email protected]> Signed-off-by: keithfz <[email protected]>
Signed-off-by: Keith Zeto <[email protected]> Signed-off-by: keithfz <[email protected]>
Signed-off-by: keithfz <[email protected]>
…ange Signed-off-by: keithfz <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Made some changes to facilitate further growth better, and to simplify potential comparison checks people may want to do at some point:
|
Awesome! Changes make sense to me. Should we also update the docs accordingly for the new path you’ve added?
|
@@ -143,7 +143,7 @@ Expect other useful variables to be added in the future. | |||
|
|||
| Name | Type | Description | | |||
|------|------|-------------| | |||
| `ctx` | `object` | `string` fields `project`, `stage`, and `promotion` provide convenient access to details of a `Promotion`. | | |||
| `ctx` | `object` | `string` fields `project`, `stage`, `promotion`, and `creator` provide convenient access to details of a `Promotion`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should update this to new field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this still needs to be updated, but I am struggling to find the best way to address this as we seem to be running into the limitations of using tables.
Signed-off-by: Hidde Beydals <[email protected]>
As a prerequisite to adopting Kargo, we want to be able to include information about the user triggering the promotion in our promotion templates. Specifically so the authenticated user triggering a promotion is tracked in the Git history of our GitOps repo.
To implement this, I followed the same pattern & logic used by the
Created By
column in the frontend where we parse thekargo.akuity.io/create-actor
annotation. If it doesn't exist, we returnN/A
. This gets added to the promotion context, and can then be exposed in an expression.kargo/ui/src/features/stage/promotions.tsx
Lines 150 to 155 in 29e6fb8
For our use case around auditability in the commit history, this suffices.
Relates to issue: #3081