Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Bitbucket provider in gitprovider #3209

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chamodshehanka
Copy link

@chamodshehanka chamodshehanka commented Jan 4, 2025

Closes: #2569

Added support for Bitbucket provider in gitprovider.
For now I opened a WIP PR

TODO

  • Complete the convertBitbucketPR function
  • Handle the interface{} type - The Bitbucket library returns interface{} for some fields. You need to properly type assert these fields to extract the necessary information
  • Test the implementation

@chamodshehanka chamodshehanka requested a review from a team as a code owner January 4, 2025 16:34
Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for docs-kargo-io canceled.

Name Link
🔨 Latest commit d8f6310
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/67e46e57698b6e0008946909

@krancour krancour added this to the v1.3.0 milestone Feb 4, 2025
@chamodshehanka chamodshehanka changed the title [WIP] feat: Add support for Bitbucket provider in gitprovider feat: Add support for Bitbucket provider in gitprovider Feb 22, 2025
@krancour krancour modified the milestones: v1.3.0, v1.4.0 Feb 23, 2025
@chamodshehanka
Copy link
Author

chamodshehanka commented Mar 16, 2025

@krancour could you please help/guide me to up and running this in local, so can test this implementation?

Thanks

@hiddeco
Copy link
Contributor

hiddeco commented Mar 24, 2025

Hey @chamodshehanka,

Information about how Kargo can be run locally can be found here: https://docs.kargo.io/contributor-guide/hacking-on-kargo#iterating-quickly

However, as we would like to have this included in 1.4.0. You can leave this with me for now, and I will do the due diligence on rebasing and testing this pull request if this is alright with you.

@chamodshehanka
Copy link
Author

hiddeco

Thanks for sharing the guide. yah! That's totally fine with me.

@hiddeco hiddeco force-pushed the feature/bitbucket-provider branch from 58ff091 to 5ad0141 Compare March 25, 2025 21:11
@chamodshehanka chamodshehanka marked this pull request as ready for review March 26, 2025 02:50
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 1.27389% with 155 lines in your changes missing coverage. Please review.

Project coverage is 21.77%. Comparing base (1ecfb0c) to head (d8f6310).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/gitprovider/bitbucket/bitbucket.go 1.27% 155 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3209      +/-   ##
==========================================
- Coverage   21.92%   21.77%   -0.16%     
==========================================
  Files         312      313       +1     
  Lines       65226    65728     +502     
==========================================
+ Hits        14302    14313      +11     
- Misses      50155    50645     +490     
- Partials      769      770       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Properly configure token authentication
- Set repository owner and repo slug at all times
- Properly consume responses
- Minimize pull request shim to fields we use
- Properly JSON roundtrip response
- Restrict implementation to Bitbucket Cloud (i.e. bitbucket.org)
- Properly register provider in runners

Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
Copy link
Contributor

hiddeco commented Mar 26, 2025

Due to the remaining // TODOs in the last commit, I do not think we will be able to include this in the upcoming 1.4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promotion / create PR feature for Bitbucket server
3 participants