-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Bitbucket provider in gitprovider #3209
base: main
Are you sure you want to change the base?
feat: Add support for Bitbucket provider in gitprovider #3209
Conversation
✅ Deploy Preview for docs-kargo-io canceled.
|
@krancour could you please help/guide me to up and running this in local, so can test this implementation? Thanks |
Hey @chamodshehanka, Information about how Kargo can be run locally can be found here: https://docs.kargo.io/contributor-guide/hacking-on-kargo#iterating-quickly However, as we would like to have this included in 1.4.0. You can leave this with me for now, and I will do the due diligence on rebasing and testing this pull request if this is alright with you. |
Thanks for sharing the guide. yah! That's totally fine with me. |
Signed-off-by: chamodshehanka <[email protected]>
Co-authored-by: Kent Rancourt <[email protected]>
Signed-off-by: chamodshehanka <[email protected]>
58ff091
to
5ad0141
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3209 +/- ##
==========================================
- Coverage 21.92% 21.77% -0.16%
==========================================
Files 312 313 +1
Lines 65226 65728 +502
==========================================
+ Hits 14302 14313 +11
- Misses 50155 50645 +490
- Partials 769 770 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Properly configure token authentication - Set repository owner and repo slug at all times - Properly consume responses - Minimize pull request shim to fields we use - Properly JSON roundtrip response - Restrict implementation to Bitbucket Cloud (i.e. bitbucket.org) - Properly register provider in runners Signed-off-by: Hidde Beydals <[email protected]>
Due to the remaining |
Closes: #2569
Added support for Bitbucket provider in gitprovider.
For now I opened a WIP PR
TODO