Feature/add versioning in apis #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayushaga14
reviewed
May 26, 2025
| // TODO: handle exception | ||
| return false; | ||
| } | ||
| return true; |
There was a problem hiding this comment.
if version <=0, this will return true
ayushaga14
reviewed
May 26, 2025
| this.mergeUrlsOnVersions = mergeUrlsOnVersions; | ||
| } | ||
|
|
||
| public boolean isSkipMergingOnKnownStaticURLsForVersionedApis() { |
There was a problem hiding this comment.
getter of that boolean, auto-generated
ayushaga14
reviewed
May 26, 2025
| @@ -73,6 +72,10 @@ public class APICatalogSync { | |||
| public Map<SensitiveParamInfo, Boolean> sensitiveParamInfoBooleanMap; | |||
| public static boolean mergeAsyncOutside = true; | |||
| public BloomFilter<CharSequence> existingAPIsInDb = BloomFilter.create(Funnels.stringFunnel(Charsets.UTF_8), 1_000_000, 0.001 ); | |||
| private boolean skipMergingOnKnownStaticURLsForVersionedApis = false; | |||
There was a problem hiding this comment.
why is this false by default?
There was a problem hiding this comment.
Coz for retrospective fix only we need that, not by default
ayushaga14
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.