remove some new object init calls #2360
Conversation
| }, | ||
| apiInfoKey); | ||
|
|
||
| varMap.clear(); |
There was a problem hiding this comment.
No need to do resolve var map ?
There was a problem hiding this comment.
no, varmap basically contains all the variables via extract command, or wordlist variables. Right now our threat templates are simple, can add this later on
| if (filterNode == null) return filterNodeNullResp; | ||
| if (rawApi == null) return rawApiNullResp; |
There was a problem hiding this comment.
we can use a single object as well
if (filterNode == null) return nullResp.modify(String.format(filterNode.className() is null));;
if (rawApi == null) return nullResp.modify(String.format(rawApi.className() is null));
|
|
||
| public final class FilterAction { | ||
|
|
||
| private final DataOperandFilterRequest dataOperandFilterRequest = new DataOperandFilterRequest(); |
There was a problem hiding this comment.
this should be private static final??
| this.operand = operand; | ||
| } | ||
|
|
||
| public DataOperandFilterRequest modify(Object data, Object queryset, String operand) { |
There was a problem hiding this comment.
This whole class is a subset of filterActionRequest with one extra field data.
What if we delete this whole class and just use the filterActionRequest ??
There was a problem hiding this comment.
no performance impact for now, let's do this later
gauravakto
left a comment
gauravakto
left a comment
There was a problem hiding this comment.
check minor comments, looks fine to me
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 5969429 | Triggered | JSON Web Token | e1203f3 | apps/testing/src/test/java/com/akto/testing/FilterValidationTests.java | View secret |
| 16611904 | Triggered | Generic High Entropy Secret | e1203f3 | apps/testing/src/test/java/com/akto/testing/FilterValidationTests.java | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
No description provided.