Skip to content

remove some new object init calls #2360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ayushaga14
Copy link
Contributor

No description provided.

},
apiInfoKey);

varMap.clear();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to do resolve var map ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, varmap basically contains all the variables via extract command, or wordlist variables. Right now our threat templates are simple, can add this later on

Comment on lines 365 to 366
if (filterNode == null) return filterNodeNullResp;
if (rawApi == null) return rawApiNullResp;
Copy link
Contributor

@gauravakto gauravakto Apr 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use a single object as well

        if (filterNode == null) return nullResp.modify(String.format(filterNode.className() is null));;
        if (rawApi == null) return nullResp.modify(String.format(rawApi.className() is null));

@@ -48,6 +48,8 @@
import static com.akto.runtime.utils.Utils.parseKafkaMessage;

public final class FilterAction {

private final DataOperandFilterRequest dataOperandFilterRequest = new DataOperandFilterRequest();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be private static final??

@@ -40,4 +40,11 @@ public void setOperand(String operand) {
this.operand = operand;
}

public DataOperandFilterRequest modify(Object data, Object queryset, String operand) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole class is a subset of filterActionRequest with one extra field data.

What if we delete this whole class and just use the filterActionRequest ??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no performance impact for now, let's do this later

Copy link
Contributor

@gauravakto gauravakto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check minor comments, looks fine to me

Copy link

gitguardian bot commented Apr 15, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
5969429 Triggered JSON Web Token e1203f3 apps/testing/src/test/java/com/akto/testing/FilterValidationTests.java View secret
16611904 Triggered Generic High Entropy Secret e1203f3 apps/testing/src/test/java/com/akto/testing/FilterValidationTests.java View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants