Skip to content

"Skipped" renamed to "Not applicable" #2222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

"Skipped" renamed to "Not applicable" #2222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions ...b/polaris_web/web/src/apps/dashboard/pages/testing/SingleTestRunPage/SingleTestRunPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,12 @@ let filterOptions = [

function SingleTestRunPage() {

const [testRunResultsText, setTestRunResultsText] = useState({ vulnerable: [], no_vulnerability_found: [], skipped: [], need_configurations: [], ignored_issues: [] })
const [testRunResultsText, setTestRunResultsText] = useState({ vulnerable: [], no_vulnerability_found: [], not_applicable: [], need_configurations: [], ignored_issues: [] })
const [selectedTestRun, setSelectedTestRun] = useState({});
const subCategoryFromSourceConfigMap = PersistStore(state => state.subCategoryFromSourceConfigMap);
const params = useParams()
const [loading, setLoading] = useState(false);
const [tempLoading, setTempLoading] = useState({ vulnerable: false, no_vulnerability_found: false, skipped: false, running: false, need_configurations: false, ignored_issues: false })
const [tempLoading, setTempLoading] = useState({ vulnerable: false, no_vulnerability_found: false, not_applicable: false, running: false, need_configurations: false, ignored_issues: false })
const [selectedTab, setSelectedTab] = useState("vulnerable")
const [selected, setSelected] = useState(0)
const [workflowTest, setWorkflowTest] = useState(false);
Expand Down Expand Up @@ -156,7 +156,7 @@ function SingleTestRunPage() {
const tableTabMap = {
vulnerable: "VULNERABLE",
domain_unreachable: "SKIPPED_EXEC_API_REQUEST_FAILED",
skipped: "SKIPPED_EXEC",
not_applicable: "SKIPPED_EXEC",
need_configurations: "SKIPPED_EXEC_NEED_CONFIG",
no_vulnerability_found: "SECURED",
ignored_issues: "IGNORED_ISSUES"
Expand Down Expand Up @@ -193,7 +193,7 @@ function SingleTestRunPage() {
const tableTabsOrder = [
"vulnerable",
"need_configurations",
"skipped",
"not_applicable",
"no_vulnerability_found",
"domain_unreachable",
"ignored_issues"
Expand Down Expand Up @@ -332,7 +332,7 @@ function SingleTestRunPage() {
await api.fetchTestingRunResults(localSelectedTestRun.testingRunResultSummaryHexId, tableTabMap[selectedTab], sortKey, sortOrder, skip, limit, filters, queryValue).then(({ testingRunResults, errorEnums, issueslistCount }) => {
ignoredIssueListCount = issueslistCount
testRunResultsRes = transform.prepareTestRunResults(hexId, testingRunResults, localSubCategoryMap, subCategoryFromSourceConfigMap)
if (selectedTab === 'domain_unreachable' || selectedTab === 'skipped' || selectedTab === 'need_configurations') {
if (selectedTab === 'domain_unreachable' || selectedTab === 'Not applicable' || selectedTab === 'need_configurations') {
errorEnums['UNKNOWN_ERROR_OCCURRED'] = "OOPS! Unknown error occurred."
setErrorsObject(errorEnums)
setMissingConfigs(transform.getMissingConfigs(testRunResultsRes))
Expand Down Expand Up @@ -479,7 +479,7 @@ function SingleTestRunPage() {
</div> : null
)

const definedTableTabs = ['Vulnerable', 'Need configurations', 'Skipped', 'No vulnerability found', 'Domain unreachable', 'Ignored Issues']
const definedTableTabs = ['Vulnerable', 'Need configurations', 'Not applicable', 'No vulnerability found', 'Domain unreachable', 'Ignored Issues']

const { tabsInfo } = useTable()
const tableCountObj = func.getTabsCount(definedTableTabs, {}, Object.values(testRunResultsCount))
Expand Down
2 changes: 1 addition & 1 deletion apps/dashboard/web/polaris_web/web/src/apps/dashboard/pages/testing/transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1102,7 +1102,7 @@ getHeaders: (tab)=> {
case "no_vulnerability_found":
return headers.filter((header) => header.title !== "Severity")

case "skipped":
case "not_applicable":
return headers.filter((header) => header.title !== "CWE tags").map((header) => {
if (header.title === "Severity") {
// Modify the object as needed
Expand Down
Loading