Add note about limitation of the plugin. #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklajnert
requested changes
Apr 9, 2023
There was a problem hiding this comment.
Thank you for your contribution. I think that this note should be put into README.rst, in the end of the Usage section. That way it will be also visible on GitHub. Perhaps, there should be two examples - good and bad one. Also, I think it will work with from subprocess import Popen in some cases, but it may not be reliable
|
I think what it's most disorienting it's that the examples are all testing directly the I'll rework the PR to include some good and bad examples, hopefully before next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify subtle limitation of this plugin as noted in #116