fix: DynamoDB evict offsets per slice #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Nov 18, 2024
patriknw
commented
- don't use evicted state when saving changed timestamp per slice
- evict time window for each slice
- remove keep-number-of-entries and evict-interval
* don't use evicted state when saving changed timestamp per slice * evict time window for each slice * remove keep-number-of-entries and evict-interval
patriknw
force-pushed
the
wip-evict-patriknw
branch
from
d058680 to
f8f9d2e
Compare
|
@leviramsey please review this |
johanandren
approved these changes
Nov 18, 2024
|
some samples failed, but that is unrelated and fixed in #1248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.