feat/fix: skip backtracking when far behind, accept pubsub events after idle #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
reviewed
Nov 14, 2024
There was a problem hiding this comment.
Looking good. This is a port of akka/akka-persistence-r2dbc#614. Anything that is different or that we should watch out for compared to that PR?
|
The heartbeat-per-slice is perhaps what I'm most uncertain of (especially wrt to pubsub... maybe it makes sense with this to move pubsub to per-slice (merge slices after pubsub) and default the pubsub topics to 1024?), since R2DBC is heartbeat per slice-range. |
|
I think the link validator is expected (or is another PR)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #95
Will need to add a test for pubsub after idle.