fix: don't set idle when backtracking, check for forward behind latest backtracking #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leviramsey
commented
Nov 28, 2024
| @@ -300,7 +300,7 @@ import org.slf4j.Logger | |||
| } | |||
|
|
|||
| def nextQuery(state: QueryState): (QueryState, Option[Source[Envelope, NotUsed]]) = { | |||
| val newIdleCount = if (state.itemCount == 0) state.idleCount + 1 else 0 | |||
| val newIdleCount = if (state.itemCount == 0 && !state.backtracking) state.idleCount + 1 else 0 | |||
There was a problem hiding this comment.
Since the backtracking query has a definite endpoint in the past, it's not unexpected that a query would return zero items nor would returning zero items suggest anything about whether we're caught up.
leviramsey
commented
Nov 28, 2024
| case Some(latestBacktracking) if latestBacktracking.isAfter(t.timestamp) && log.isInfoEnabled => | ||
| val errStr = s"event from query for persistenceId ${env.persistenceId} seqNr ${env.sequenceNr} " + | ||
| s"timestamp ${t.timestamp} was before last event from backtracking or heartbeat $latestBacktracking." | ||
| log.info(errStr) |
There was a problem hiding this comment.
Could maybe make this debug or throttle in some way... an info log per event might be overkill, but a debug is probably too likely to get lost.
This isn't necessarily a problem, since it will arise if starting from idle in a slice
patriknw
force-pushed
the
idle-backtracking-fix
branch
from
1d3fb3d to
6ae1c13
Compare
patriknw
reviewed
Nov 28, 2024
| val newIdleCountBeforeHeartbeat = | ||
| if (state.backtracking) state.idleCountBeforeHeartbeat | ||
| else if (state.itemCount == 0) state.idleCountBeforeHeartbeat + 1 | ||
| else 0 |
There was a problem hiding this comment.
I think I want to play safe here. The idleCount is used for something else so I don't want to risk breaking that.
|
Refs #95 |
This was referenced Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.