Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake_https option, use hooks to modify base string #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LitoMore
Copy link
Contributor

Breaking

Remove fake_https option, use hooks instead.

Usage

client = fanfou.XAuth(
    consumer,
    'username',
    'password',
    https=True,
    hooks={
        'base_string': lambda s: s.replace('https', 'http')
    }
)

fake_https is not a good variable name. Our request is still HTTPS, but the base string used in the OAuth signing process is different from the standard process.

The name hooks is more expressive of specific functions, and we can also make more customized changes through hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant