Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout value to cli, fix metadata error, cross builds, update dependencies #39

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sero01000
Copy link

  1. Added timeout argument to cli
    1.1 Default timeout changed from 0.05 seconds to 1 second
  2. Fixed metadata error for windows
  3. Update cargo.toml for better link time optimizations and update all crates version
  4. Cross build and release action for 20 platforms

Update cargo.toml for better link time optimizations and bump all crates version
bulds for:
	aarch64-pc-windows-msvc
	i686-pc-windows-msvc-i686
	x86_64-pc-windows-msvc

	aarch64-linux-android
	aarch64-unknown-linux-gnu
	arm-linux-androideabi
	arm-unknown-linux-gnueabihf
	arm-unknown-linux-musleabi
	armv7-linux-androideabi
	armv7-unknown-linux-gnueabi
	armv7-unknown-linux-musleabi
	i686-unknown-linux-musl
	riscv64gc-unknown-linux-gnu
	x86_64-unknown-linux-gnu
	x86_64-unknown-linux-musl

	Apple-aarch64-apple-ios
	macOS-aarch64-apple-darwin
	macOS-x86_64-apple-darwin

	x86_64-unknown-freebsd
	x86_64-unknown-netbsd
1. Metadata error fix for target_family=windows
2. Added timeout to cli argument
1. timeout gets from cli argument
2. add timeout error
@stevelr
Copy link

stevelr commented Aug 12, 2023

Thanks for this. I ran into timeout error also, as the default 50ms wasn't sufficient (in my case, the connection was over a multi-hop vpn). I support the additional error type also: The error message for AddrTypeNotSupported isn't helpful to diagnose the timeout.
I had prepared a PR to submit these two changes then found this (oops - should have looked first!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants