Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Segments #971

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Visual Segments #971

wants to merge 2 commits into from

Conversation

ajayyy
Copy link
Owner

@ajayyy ajayyy commented Sep 26, 2021

Fix #538


Stored as SVGs with animations

While editing, stored as simpler types that are then converted to one svg per segment.

To play at different speeds, the svg must be modified to have all times multipled by the playback speed.

  • Implement editor with custom variables (bounds, etc.)
  • add method to convert these to an svg using svg.js
  • add custom display code for starting/stopping animations and playing at different speeds
  • add a filter on the server to only allow whitelisted xml tags
  • stop displaying visual segments in the seek bar?

SVG tags must be generated manually since svgjs doesn't support them. They can play fine though when imported.

https://stackoverflow.com/a/51615827/1985387

@ajayyy ajayyy changed the title Add start of visual segment editing Visual Segments Sep 26, 2021
@LoganDark
Copy link

LoganDark commented Dec 7, 2021

This seems like a fine implementation. Clients (such as the extensions) could support whatever SVG things they want to submit to the server. Circles, rectangles, gradients etc. all fair game. Of course the official extension would likely only support basic shapes for submitting, but this looks very nice and future-proof to me.

@erkinalp
Copy link

erkinalp commented Dec 3, 2022

Why did you close the server side ticket? Server change is definitely required to accommodate this remedy type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Segments: Blocking out social media icons and other intrusive visual content
3 participants