Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter complaints #5735

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Fix linter complaints #5735

merged 3 commits into from
Feb 3, 2025

Conversation

nightwing
Copy link
Member

@nightwing nightwing commented Jan 30, 2025

fixes #5732 #5733
code coverage complain can be ignored, since that part is disabled in test runner

@nightwing nightwing force-pushed the fix-linter-complaints branch from 1cc75f7 to 71c3ae2 Compare January 30, 2025 19:50
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.05%. Comparing base (6f05b92) to head (71c3ae2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/mode/_test/highlight_rules_test.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5735      +/-   ##
==========================================
- Coverage   87.06%   87.05%   -0.01%     
==========================================
  Files         598      598              
  Lines       43713    43714       +1     
  Branches     7164     7164              
==========================================
  Hits        38057    38057              
- Misses       5656     5657       +1     
Flag Coverage Δ
unittests 87.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nightwing nightwing merged commit 75fae83 into master Feb 3, 2025
2 of 3 checks passed
@nightwing nightwing deleted the fix-linter-complaints branch February 3, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

worker-javascript: contains unsafe, unused function
2 participants