Fix: wrong type of paste event and missing types for themelist extension #5725
Conversation
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
types/ace-modules.d.ts
Outdated
| @@ -890,7 +890,7 @@ declare module "ace-code/src/virtual_renderer" { | |||
| * @param {EditSession} session The session to associate with | |||
| **/ | |||
| setSession(session: EditSession): void; | |||
| session: import("ace-code/src/edit_session").EditSession; | |||
| session: import("ace-code").Ace.EditSession; | |||
There was a problem hiding this comment.
why is this change generated?
There was a problem hiding this comment.
Seems, I've got outdated version of typescript
Co-authored-by: Harutyun Amirjanyan <[email protected]>
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5725 +/- ##
=======================================
Coverage 87.05% 87.05%
=======================================
Files 598 598
Lines 43703 43703
Branches 7163 7163
=======================================
Hits 38047 38047
Misses 5656 5656
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
mkslanc
changed the title
Issue #, if available: #5723
Description of changes:
moveToMouseCould be further improved by listing theme names in types, but it would involve either manual writing those theme names, or rewriting
themeDatato have nice object structure with theme name as a key.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts) and its references: