-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Improve plugin's code structure, quality and scalability (with DDD, second implementation). #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-roots its repositories
…regate-roots its infrastructure repositories
…roots its registry management
…eModelEntity objects
…HomeAggregateRoot
…r infrastructure-repository's start-up and shutdown logic
…layerModelEntity objects
…r PlayerAggregateRoot
…n loading and unloading
…ure-repository implementations
…ure-repository implementations
…Builder for list-message format building
…ion to player's homes-array in create method
…rastructure-repository and rename private method to validateInfrastructureType
…t and catch JsonIOException exception in write function
…or JSON and Mongo codecs
…t class's id() method, remove has() method and use PlayerModelEntity#home for home-model searching through homes-array
…s in unused methods and implement interface-contract changes (methods addition and deletion, change return value)
…e directly instead of PlayerAggregateRootRegistry#save its return value, and fix array-index error in removeHome method
…res handling notifying
… create 'home' method for better home-model search
…ull values during array iteration in 'home' method
aivruu
changed the title
Refactor: Improve plugin's code structure, quality and scalability (with DDD, first implementation).
Refactor: Improve plugin's code structure, quality and scalability (with DDD, second implementation).
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking refactor with the current plugin's structure.
Changes: