Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Improve plugin's code structure, quality and scalability (with DDD, second implementation). #1

Merged
merged 91 commits into from
Dec 28, 2024

Conversation

aivruu
Copy link
Owner

@aivruu aivruu commented Dec 28, 2024

This is a breaking refactor with the current plugin's structure.

Changes:

  • Leaved old structure, now using DDD (second try of implement it, improving previous implementation).
  • Improved API things such as classes and services.
  • Now using modern APIs such as Brigadier command-api and Paper 1.21.3.

…regate-roots its infrastructure repositories
…r infrastructure-repository's start-up and shutdown logic
…ion to player's homes-array in create method
…rastructure-repository and rename private method to validateInfrastructureType
…t and catch JsonIOException exception in write function
…t class's id() method, remove has() method and use PlayerModelEntity#home for home-model searching through homes-array
…s in unused methods and implement interface-contract changes (methods addition and deletion, change return value)
…e directly instead of PlayerAggregateRootRegistry#save its return value, and fix array-index error in removeHome method
… create 'home' method for better home-model search
…ull values during array iteration in 'home' method
@aivruu aivruu merged commit a82a5c1 into main Dec 28, 2024
1 check passed
@aivruu aivruu changed the title Refactor: Improve plugin's code structure, quality and scalability (with DDD, first implementation). Refactor: Improve plugin's code structure, quality and scalability (with DDD, second implementation). Dec 28, 2024
@aivruu aivruu deleted the refactor/rework-with-ddd branch December 28, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant