Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak RabbitMQ queue argument lists #2148

Merged

Conversation

Arseniy-Popov
Copy link
Contributor

@Arseniy-Popov Arseniy-Popov commented Mar 25, 2025

Description

RabbitMQ queue declaration argument lists were updated to reflect the RabbitMQ's source code found in:

  1. x-max-priority is not supported by quorum queues, only by classic queues: rabbitmq.com/docs/priority#overview.
  2. x-queue-master-locator is the legacy naming of x-queue-leader-locator that is still supported by classic queues: rabbitmq.com/docs/clustering#replica-placement
  3. x-queue-version and x-queue-mode are supported for classic queues by older versions of RabbitMQ: rabbitmq.com/blog/2023/05/17/rabbitmq-3.12-performance-improvements#classic-queues-changes-to-the-lazy-mode
  4. x-max-in-memory-bytes and x-max-in-memory-length are supported for quorum queues by older versions of RabbitMQ: rabbitmq.com/blog/2020/04/20/rabbitmq-gets-an-ha-upgrade#quorum-queues-in-the-management-ui

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@Lancetnik Lancetnik added enhancement New feature or request RabbitMQ Issues related to `faststream.rabbit` module and RabbitMQ broker features labels Mar 28, 2025
@Lancetnik Lancetnik added this pull request to the merge queue Mar 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 28, 2025
@Lancetnik Lancetnik added this pull request to the merge queue Mar 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 28, 2025
@Lancetnik Lancetnik enabled auto-merge March 29, 2025 16:21
@Lancetnik Lancetnik added this pull request to the merge queue Mar 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 29, 2025
@Lancetnik Lancetnik added this pull request to the merge queue Mar 29, 2025
Merged via the queue into airtai:main with commit 5641cf6 Mar 29, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RabbitMQ Issues related to `faststream.rabbit` module and RabbitMQ broker features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants