Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Analytics] Location naming alignment and modified map search logic #2027

Merged
merged 15 commits into from
May 27, 2024
Merged

[Analytics] Location naming alignment and modified map search logic #2027

merged 15 commits into from
May 27, 2024

Conversation

Codebmk
Copy link
Member

@Codebmk Codebmk commented May 23, 2024 •
edited by jira bot
Loading

Summary of Changes (What does this PR do?)

  • Replaced logic for map search to utilize google places api
  • Updated air quality card location cards and charts names to match customised locations(common and more user friendly names)

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets?

Screenshots (optional)

image
image
image

@Codebmk Codebmk self-assigned this May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@Codebmk Codebmk requested a review from Baalmart May 27, 2024 08:09
@Codebmk Codebmk changed the title [Analytics] Customise functionality improvements [Analytics] Location naming alignment and modified map search logic May 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

Baalmart
Baalmart approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Codebmk

@Baalmart Baalmart merged commit 517acf4 into staging May 27, 2024
28 of 29 checks passed
@Baalmart Baalmart deleted the hotfix-customise-fx branch May 27, 2024 11:43
@Baalmart Baalmart mentioned this pull request May 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart approved these changes

Assignees

@Codebmk Codebmk

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Codebmk @Baalmart