Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[S3-data-lake] Re-enable the Nessie integration tests #53622

Merged
merged 11 commits into from
Feb 11, 2025
Merged

[S3-data-lake] Re-enable the Nessie integration tests #53622

merged 11 commits into from
Feb 11, 2025
+65 −57

Conversation

frifriSF59
Copy link
Contributor

@frifriSF59 frifriSF59 commented Feb 10, 2025 •
edited
Loading

What

Enable the Nessie integration tests.
They were previously failing in CI and are now fixed.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@frifriSF59 frifriSF59 self-assigned this Feb 10, 2025
@vercel Vercel
Copy link

vercel bot commented Feb 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 11, 2025 7:19pm

@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Feb 10, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (1dee586)

@frifriSF59 frifriSF59 force-pushed the frifri/nessie-int-test-reactivated branch from 1dee586 to 8a32c1b Compare February 10, 2025 22:42
@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Feb 11, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

❌ Job failed.

@frifriSF59 frifriSF59 force-pushed the frifri/nessie-int-test-reactivated branch from 84e931e to 7c8d689 Compare February 11, 2025 16:44
@frifriSF59
Copy link
Contributor Author

frifriSF59 commented Feb 11, 2025 •
edited by github-actions bot
Loading

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (dc33a5a)

@frifriSF59 frifriSF59 marked this pull request as ready for review February 11, 2025 17:57
@frifriSF59 frifriSF59 requested a review from a team as a code owner February 11, 2025 17:57
@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 11, 2025
edgao
edgao approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@edgao edgao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a comment somewhere explaining the stuff about the port conflict, and that we can't use the getMappedPort method for some reason

@frifriSF59 frifriSF59 enabled auto-merge (squash) February 11, 2025 18:57
@frifriSF59 frifriSF59 merged commit ebedcbe into master Feb 11, 2025
28 checks passed
@frifriSF59 frifriSF59 deleted the frifri/nessie-int-test-reactivated branch February 11, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgao edgao edgao approved these changes

Assignees

@frifriSF59 frifriSF59

Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3-data-lake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frifriSF59 @edgao @octavia-squidington-iii