Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Zendesk Support: Replace ZendeskSupportAuditLogsIncrementalSync with low-code #53620

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pabloescoder
Copy link
Collaborator

@pabloescoder pabloescoder commented Feb 10, 2025

What

Resolves https://github.com/airbytehq/airbyte-internal-issues/issues/11511

How

By replacing ZendeskSupportAuditLogsIncrementalSync with low-code DatetimeBasedCursor and adding a request param to filter records by stream_interval start and end time.

Review guide

  1. manifest.yaml
  2. components.py

User Impact

No impact, enables concurrent CDK framework.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Acceptance Criteria

  • The audit_logs stream no longer defines the custom component ZendeskSupportAuditLogsIncrementalSync
  • The audit_logs stream supports incremental syncs
  • ZendeskSupportAuditLogsIncrementalSync is deleted from components.py
  • All tests in /unit_tests pass.
  • All CI checks are passing ✅
  • Live traffic regression test suite run with passing results
  • Progressive rollout starting with 20%, 50%, followed by release of the candidate version

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 10, 2025 9:21pm

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Feb 10, 2025
@pabloescoder
Copy link
Collaborator Author

pabloescoder commented Feb 10, 2025

/format-fix

Format-fix job started... Check job output.

✅ Changes applied successfully. (2e82b0e)

@brianjlai
Copy link
Contributor

brianjlai commented Feb 11, 2025

@DanyloGL let's kickoff a regression test run of source-zendesk-support running. Given the scope of @pabloescoder 's changes, we really only care about the audit_logs stream so testing against just that should be sufficient. If these look good when tested incrementally (full refresh if you want additional validation), then we can begin a progressive rollout

ah sorry my mistake, I didn't realize we'd already kicked off a run. thanks @DanyloGL . If we see no mismatches on audit_logs then I think this is ready to go. you can use the /approve-regression-tests to run the CI that will approve the regression test step after you've checked the results match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zendesk-support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants