Docs terraform context #53242
Docs terraform context #53242
Conversation
…ut the JSON version.
…ely changed the TF code sample for running BigQuery as weakly typed. Read through and did a copyedit.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
the
area/documentation
There was a problem hiding this comment.
Great job with pull requests your changes make the markdown file much more readable and engaging for new users like me. Now i still have a remark. I would increase the possibility for test driven development in this project and for future contributors. By a bulk test procedure for the most important feature of the project.
|
|
||
| - **Cloud**: [An API application](using-airbyte/configuring-api-access.md) in Airbyte, your client ID, and your client secret. | ||
|
|
||
| - **Self-Managed**: Your username and password, and if you're running locally, your server URL (usually `http://localhost:8000/api/public/v1/`). |
There was a problem hiding this comment.
I thought API applications were supported in OSS and SME as well?
There was a problem hiding this comment.
Applications are supported in SME and OSS
SME:
OSS:
I think OSS can't create multiple Applications, but it can still run with auth enabled.
| 1. Add your source to `main.tf`. | ||
|
|
||
| <Tabs> | ||
| <TabItem value="Strongly typed" label="Strongly typed" default> |
There was a problem hiding this comment.
Should we have JSON be the default rather than strongly typed?
| } | ||
| ``` | ||
| </TabItem> | ||
| <TabItem value="Self-Managed" label="Self-Managed"> |
There was a problem hiding this comment.
Perhaps we can simplify these blocks so that all users use the same client_id/secret path.
| </TabItem> | ||
| </Tabs> | ||
|
|
||
| 5. In your terminal, create a file called `variables.tf`. This file stores sensitive variables you don't want to appear in `main.tf`, plus other values you'll reuse often. |
There was a problem hiding this comment.
This seems like a weird step to me, and extra noise. Why do we need to introduce touch specifically? Can we just say "create a file named ..."?
What
Expand our Terraform stub article and add new Terraform tutorial. Resolves the docs component of #11525.
How
Expands our stub Terraform topic to be a fully-fledged Terraform tutorial. Includes new discussions and code samples, specifically around the use of JSON strings as alternatives to strongly typed configurations to help deal with Terraform drift.
Not included in this PR are two decisions we need to make about previously created resources:
Both of these resources are out of date compared to this content, and I expect they will be replaced by it. This is a fuller discussion about current challenges and, unlike those other resources, should be technically correct to the latest version of the Terraform provider.
Review guide
For the nice version, just open the linked Vercel build as usual and scroll down to Terraform Provider in the menu.
User Impact
Can this PR be safely reverted and rolled back?