-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(source-amazon-seller-partner): add app_id to server configuration #53693
Merged
artem1205
merged 6 commits into
master
from
artem1205/source-amazon-seller-partner-fix-oauth
Feb 17, 2025
Merged
ref(source-amazon-seller-partner): add app_id to server configuration #53693
artem1205
merged 6 commits into
master
from
artem1205/source-amazon-seller-partner-fix-oauth
Feb 17, 2025
+37
−1,016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[skip ci] Signed-off-by: Artem Inzhyyants <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Artem Inzhyyants <[email protected]>
bazarnov
requested changes
Feb 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but we need the app_id
in the complete_oauth_server_output_specification
of the spec.advanced_auth
section added.
...-integrations/connectors/source-amazon-seller-partner/source_amazon_seller_partner/spec.json
Show resolved
Hide resolved
Also,
backward_compatibility_tests_config:
# Add a comment here on why we do bypass
disable_for_version: "x.x.x"
|
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
bazarnov
approved these changes
Feb 17, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/connectors
Connector related issues
area/documentation
Improvements or additions to documentation
connectors/source/amazon-seller-partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Resolve #53181
Note
acceptance-test-config.yml was updated (spec for OSS removed) because OSS specific functionality was disabled during low-code migration
How
add app_id to server configuration
Review guide
User Impact
Can this PR be safely reverted and rolled back?