Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(source-amazon-seller-partner): add app_id to server configuration #53693

Merged
merged 6 commits into from
Feb 17, 2025

Conversation

artem1205
Copy link
Collaborator

@artem1205 artem1205 commented Feb 14, 2025

What

Resolve #53181

Note

acceptance-test-config.yml was updated (spec for OSS removed) because OSS specific functionality was disabled during low-code migration

How

add app_id to server configuration

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

[skip ci]

Signed-off-by: Artem Inzhyyants <[email protected]>
@artem1205 artem1205 requested a review from bazarnov February 14, 2025 16:30
@artem1205 artem1205 self-assigned this Feb 14, 2025
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 0:43am

Signed-off-by: Artem Inzhyyants <[email protected]>
Copy link
Collaborator

@bazarnov bazarnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need the app_id in the complete_oauth_server_output_specification of the spec.advanced_auth section added.

@bazarnov
Copy link
Collaborator

Also,

  1. We need also to bypass the spec check for the CAT, using the:
backward_compatibility_tests_config:
   # Add a comment here on why we do bypass
   disable_for_version: "x.x.x"
  1. We need to reflect the same changes here for the testing spec file:
    https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-amazon-seller-partner/integration_tests/spec_oss.json#L230

Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
Signed-off-by: Artem Inzhyyants <[email protected]>
@bazarnov bazarnov marked this pull request as ready for review February 17, 2025 14:03
@artem1205 artem1205 merged commit 6ad9476 into master Feb 17, 2025
27 checks passed
@artem1205 artem1205 deleted the artem1205/source-amazon-seller-partner-fix-oauth branch February 17, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/amazon-seller-partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[source-amazon-seller-partner] OAuth fails silently, missing app_id
3 participants