Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-amazon-seller-partner] OAuth fails silently, missing app_id #53181

Closed
1 task
fitzyjoe opened this issue Feb 5, 2025 · 6 comments · Fixed by #53693
Closed
1 task

[source-amazon-seller-partner] OAuth fails silently, missing app_id #53181

fitzyjoe opened this issue Feb 5, 2025 · 6 comments · Fixed by #53693

Comments

@fitzyjoe
Copy link

fitzyjoe commented Feb 5, 2025

Connector Name

amazon-seller-partner

Connector Version

4.5.0

What step the error happened?

Configuring a new connector

Relevant information

I'm using Airbyte OSS. When I create a new Amazon Seller Partner source, I specify the following:

  • Source Name
  • AWS Environment
  • AWS Region
  • AWS Seller Partner Account Type
  • LWA Client Id
  • LWA Client Secret

and then I click the button to "Authenticate your Amazon Seller Partner account". I see no visual result after clicking the button. When I view the developer tools network tab I see that my request yields a 500 response and the response body looks like this:

{
    "message": "Internal Server Error: Undefined parameter 'app_id' necessary for the OAuth Flow.",
    "exceptionClassName": "java.lang.IllegalArgumentException",
    "exceptionStack": [],
    "rootCauseExceptionStack": []
}

I see this thread seems to be related to the addition or removal of the app_id parameter:

Also docs for this connector are confusing as they reference a "Refresh Token" as a parameter for Airbyte Open Source, however no Refresh Token configuration field is found in the UI.

I wonder if this is a similar issue to the very recently reported issue with the instagram connector.

I believe I'm running Airbyte 1.4

Relevant log output

Contribute

  • Yes, I want to contribute
@fitzyjoe fitzyjoe added area/connectors Connector related issues needs-triage type/bug Something isn't working labels Feb 5, 2025
@fitzyjoe fitzyjoe changed the title OAuth fails [source-amazon-seller-partner] OAuth fails silently, missing app_id Feb 5, 2025
@fitzyjoe
Copy link
Author

fitzyjoe commented Feb 5, 2025

I have another deployment of Airbyte (1.3.1) that is running source: amazon-seller-partner version 4.4.7 and it has a field for refresh token, does not have a button called "Authenticate your Amazon Seller Partner account" and it works.

@fitzyjoe
Copy link
Author

fitzyjoe commented Feb 5, 2025

I downgraded my source to version 4.4.7 on the problem instance, but it still doesn't show a field for the Refresh Token and still does not work. I'm suspecting that perhaps the Amazon Seller Partner source is not ready for Airbyte 1.4 and I'll need to downgrade to 1.3.1.

@bazarnov
Copy link
Collaborator

bazarnov commented Feb 5, 2025

@fitzyjoe
Please share the screenshots from the Connector settings UI, including the optional fields. Thank you.

@fitzyjoe
Copy link
Author

fitzyjoe commented Feb 5, 2025

@bazarnov Here is a side-to-side screenshot comparison for the connector settings UI including the optional fields. Thanks for your help.

Image

@artem1205
Copy link
Collaborator

Hey @fitzyjoe,
fix for oauth was implemented in #53693
new field app_id (Application ID) was added to the specification, you should fill it as well.

@fitzyjoe
Copy link
Author

Thanks for the update @artem1205. I haven't had the chance to test yet. I reverted to 1.3.1 for now and will test an upgrade to 1.4 again in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants