Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve blur effect accuracy #2571

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Commits on Nov 4, 2024

  1. Configuration menu
    Copy the full SHA
    26f6f6c View commit details
    Browse the repository at this point in the history
  2. Remove debug stuff

    geomaster committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6dfcfed View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Fix blur radius inconsistencies

    Be more careful about the sigma->radius conversion, blur propagation,
    and don't forget to undo the pre-existing scale for the RenderEffect
    impl. It seems that all implementations of blur we have now - mask
    filter, CPU blur, and RenderEffect blur - look mostly the same.
    geomaster committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    bc516c4 View commit details
    Browse the repository at this point in the history
  2. Much faster CPU blur

    Based on the old box blur algorithm with a running sum, write a new one
    that is more readable and more performant, due mostly to avoiding the
    use of Bitmap.getPixels() and Bitmap.setPixels().
    
    The blur is still, well, boxy, which we will probably be able to fix by
    stacking two invocations of it, or trying some trickery to approximate
    the Guassian kernel better but still keeping the linear time complexity.
    geomaster committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4f62b70 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    9abd8a6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    108060a View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    a8591a7 View commit details
    Browse the repository at this point in the history
  2. Use IntBuffer instead of ByteBuffer for FastBlur

    Seems to provide slightly better perf.
    geomaster committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1ee89ee View commit details
    Browse the repository at this point in the history
  3. Tidy and add docs

    geomaster committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4f2ae70 View commit details
    Browse the repository at this point in the history