-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve blur effect accuracy #2571
Open
geomaster
wants to merge
9
commits into
airbnb:master
Choose a base branch
from
geomaster:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 4, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 26f6f6c - Browse repository at this point
Copy the full SHA 26f6f6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dfcfed - Browse repository at this point
Copy the full SHA 6dfcfedView commit details
Commits on Nov 6, 2024
-
Fix blur radius inconsistencies
Be more careful about the sigma->radius conversion, blur propagation, and don't forget to undo the pre-existing scale for the RenderEffect impl. It seems that all implementations of blur we have now - mask filter, CPU blur, and RenderEffect blur - look mostly the same.
Configuration menu - View commit details
-
Copy full SHA for bc516c4 - Browse repository at this point
Copy the full SHA bc516c4View commit details -
Based on the old box blur algorithm with a running sum, write a new one that is more readable and more performant, due mostly to avoiding the use of Bitmap.getPixels() and Bitmap.setPixels(). The blur is still, well, boxy, which we will probably be able to fix by stacking two invocations of it, or trying some trickery to approximate the Guassian kernel better but still keeping the linear time complexity.
Configuration menu - View commit details
-
Copy full SHA for 4f62b70 - Browse repository at this point
Copy the full SHA 4f62b70View commit details
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9abd8a6 - Browse repository at this point
Copy the full SHA 9abd8a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 108060a - Browse repository at this point
Copy the full SHA 108060aView commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a8591a7 - Browse repository at this point
Copy the full SHA a8591a7View commit details -
Use IntBuffer instead of ByteBuffer for FastBlur
Seems to provide slightly better perf.
Configuration menu - View commit details
-
Copy full SHA for 1ee89ee - Browse repository at this point
Copy the full SHA 1ee89eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4f2ae70 - Browse repository at this point
Copy the full SHA 4f2ae70View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.