Improve performance of the quoters

[bdraco]

same change as aio-libs/aiohttp#9603

[codspeed-hq]

CodSpeed Performance Report

Merging #1407 will not alter performance

_{Comparing quoter_perf (47a261c) with master (dfc41db)}

Summary

✅ 83 untouched benchmarks

[codecov]

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.01%. Comparing base (dfc41db) to head (47a261c).

Files with missing lines	Patch %	Lines
yarl/_quoting_c.pyx	44.44%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
- Coverage   96.06%   96.01%   -0.05%     
==========================================
  Files          31       31              
  Lines        5765     5769       +4     
  Branches      344      344              
==========================================
+ Hits         5538     5539       +1     
- Misses        201      204       +3     
  Partials       26       26              

Flag	Coverage Δ
CI-GHA	96.01% <44.44%> (-0.05%)	⬇️
MyPy	48.68% <ø> (ø)
OS-Linux	99.49% <44.44%> (-0.07%)	⬇️
OS-Windows	99.61% <ø> (ø)
OS-macOS	99.23% <44.44%> (-0.07%)	⬇️
Py-3.10.11	99.21% <44.44%> (-0.07%)	⬇️
Py-3.10.15	99.45% <44.44%> (-0.07%)	⬇️
Py-3.11.10	99.45% <44.44%> (-0.07%)	⬇️
Py-3.11.9	99.21% <44.44%> (-0.07%)	⬇️
Py-3.12.7	99.45% <44.44%> (-0.07%)	⬇️
Py-3.13.0	99.45% <44.44%> (-0.07%)	⬇️
Py-3.9.13	99.17% <44.44%> (-0.07%)	⬇️
Py-3.9.20	99.40% <44.44%> (-0.07%)	⬇️
Py-pypy7.3.16	99.53% <ø> (ø)
Py-pypy7.3.17	99.55% <ø> (ø)
VM-macos-latest	99.23% <44.44%> (-0.07%)	⬇️
VM-ubuntu-latest	99.49% <44.44%> (-0.07%)	⬇️
VM-windows-latest	99.61% <ø> (ø)
pytest	99.49% <44.44%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bdraco]

Looks like its already better optimized here

[asvetlov]

Could you please postpone the merge until tomorrow. I'd like to dig in deeper a little

[bdraco]

This one didn't show enough performance change to make it worth it.

aio-libs/aiohttp#9603 does though. Already left a note there that it needs a "second set of 👀"

[asvetlov]

Well, I've looked on Cython generated code.
Fast path (when a error is not raised) is equally fast for both versions.
Error path shouldn't be optimized at all, a chance to get out-of-memory error is negligible. It should be processed, sure; but spending time to optimize it doesn't make sense.

[bdraco]

I agree, that's why I closed this one