🐛 Use compatible pytest < 8 when running MyPy against Python 3.7
#937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need a news fragment for these trivial fixes? I don't think so. |
|
@webknjaz, as you can see, this PR fixes CI failures. The only reason for the ❌ mark is the Timeline protection which, I believe, might be skipped in this case. |
|
Please, make atomic PRs. The one with testing fixes would need a |
|
I merged dependabot's PR for cibuildwheel. MyPy bump should be separate, but there's no rush to do that — it doesn't seem related and I'm fine waiting for dependabot to send a PR, it's not a priority. |
psf-chronographer
bot
added
the
bot:chronographer:provided
webknjaz
reviewed
Feb 1, 2024
webknjaz
reviewed
Feb 1, 2024
Jamim
changed the title
webknjaz
reviewed
Feb 1, 2024
Jamim
force-pushed
the
fix/ci
branch
2 times, most recently
from
f83450d
to
e85c449
Compare
Co-authored-by: Sviatoslav Sydorenko <[email protected]>
webknjaz
changed the title
pytest < 8 when running MyPy against Python 3.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @webknjaz,
What do these changes do?
These changes:
pytest/mypycompatibility issue for Python 3.72.16.5Are there changes in behavior for the user?
Issues on CI will be resolved.
Related issue number
Checklist
Best regards!