ADDED: typing to cached.__call__ #880
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in other issues/PRs, typing won't work in this library until the preceding steps in the milestone are complete: https://github.com/aio-libs/aiocache/milestone/8 Feel free to contribute by picking up the tasks starting from the top of that milestone. |
Kilo59
reviewed
Aug 13, 2024
| @@ -2,13 +2,17 @@ | |||
| import functools | |||
| import inspect | |||
| import logging | |||
| from typing import Any, Awaitable, Callable, ParamSpec, TypeVar | |||
There was a problem hiding this comment.
You'll need to use typing_extensions to support older versions of python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Adds typing support for functions decorated with
@cached()Are there changes in behavior for the user?
No
Related issue number
null
Checklist