code objects analysis replaced with inspect #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multi_cached
works incorrectly with decorated functions, called withkeys_from_attr
value passed as positional argument, example:This problem's reason is analysis of code object of function passed to
multi_cached
decorator.To properly get arguments from function decorated with
functools.wraps
, it's required to get signature of inner function. Which can be accessed by__wrapped__
attribute, or byinspect.signature
function, which goes recursively through__wrapped__
attributes till core function.I suggest to used
inspect.signature
instead of direct code obejects inteaction.