Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument clarity and improving Examples #192

Merged
merged 5 commits into from
Feb 10, 2025
Merged

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Feb 10, 2025

Closes #191

References #184

Checklist for the author of this PR:

  • [if package files were edited] I have run these checks locally:
    • devtools::document() to generates the .Rd files from any updated roxygen comments.
    • lintr::lint_package(path = ".") to check for style compliance and syntax issues.
    • codemetar::write_codemeta() to ensures the metadata file is up to date.
    • devtools::check() for a comprehensive package check. I have resolved any warnings or errors, or written them here in the PR, for discussion.
  • The code base and the documentation files match (they both reflect any recent changes).
  • The title of this PR is clear and self-explantory.
  • I have added any appropriate labels to this PR.
  • This PR is now ready for review (and I have removed the draft PR status).

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 10, 2025
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
R/map_compare.R 100.00% <ø> (ø)
R/map_convert.R 100.00% <100.00%> (ø)
R/metadata_map.R 73.05% <100.00%> (ø)

@RayStick RayStick marked this pull request as ready for review February 10, 2025 15:38
@RayStick RayStick merged commit 4b49c65 into main Feb 10, 2025
9 checks passed
@RayStick RayStick deleted the map_convert_R1-2_R1-7 branch February 10, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument clarity and improving Examples (R1-2 and R1-7)
1 participant