-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve accessibility of links & clarify technical language & correct spelling #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the name of the file also be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the function 'consensus_on_mismatch' is within
https://github.com/aim-rsf/mapmetadata/blob/R2-2_R2-3_R2-5/R/compare.R
So we should be sorted on all the renaming :)
Let me know if I am missing something!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could have been clearer - apologies! The file itself is called test-consensus_on_mistmatch.R and now that the function has been changed the file name should change too I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I follow =D
This filename has been changed in the branch: https://github.com/aim-rsf/mapmetadata/blob/R2-2_R2-3_R2-5/tests/testthat/test-consensus_on_mismatch.R
Is that what you mean? Apologies if I am missing something obvious
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in it used to be
tests/testthat/test-concensus_on_mismatch.R
now it is
tests/testthat/test-consensus_on_mismatch.R
Codecov ReportAttention: Patch coverage is
|
@Lextuga007 thanks for your comments, I am going to merge this branch into main if that's okay |
Closes #185
@Lextuga007 this PR is responding to 3 of your review comments, are you okay to review it? No problem if not, I can get another collaborator to do so. I just wanted to check I had responded to your comments appropriately, specifically regarding accessibility of links.
Checklist for the author of this PR:
devtools::document()
to generates the.Rd
files from any updated roxygen comments.codemetar::write_codemeta()
to ensures the metadata file is up to date.styler::style_pkg()
to ensure consistent code styling that match the guidelines.devtools::check()
for a comprehensive package check. I have resolved any warnings or errors, or written them here in the PR, for discussion.