Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport: refactor has_magic #6749

Closed
wants to merge 1 commit into from

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented Feb 7, 2025

has_magic is a non-descriptive name, @agoscinski suggests for refactoring.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.08%. Comparing base (8c5c709) to head (54ee38a).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/aiida/transports/plugins/ssh_async.py 66.67% 3 Missing ⚠️
src/aiida/engine/daemon/execmanager.py 66.67% 1 Missing ⚠️
src/aiida/transports/plugins/local.py 88.89% 1 Missing ⚠️
src/aiida/transports/plugins/ssh.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6749   +/-   ##
=======================================
  Coverage   78.08%   78.08%           
=======================================
  Files         564      564           
  Lines       42547    42547           
=======================================
  Hits        33219    33219           
  Misses       9328     9328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agoscinski
Copy link
Contributor

agoscinski commented Feb 7, 2025

Ah sorry, for this misunderstanding. It was just a comment that I don't like the name, not a suggestion to change it in a separate PR. I am not sure if we break the public API by doing this which goes back again to the discussion in PR #6636 and #6722. I just leave this PR open until we have settled on what is our public API.

@khsrali khsrali closed this Feb 11, 2025
@khsrali
Copy link
Contributor Author

khsrali commented Feb 11, 2025

One can always refactor by providing a deprecation path.
But I agree, it's not that important to change this anyways..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants