Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoteStashCompressedData: new data class providing compression modes when stashing #6746

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented Feb 6, 2025

Provides new functionality to compress data when stashing. This is useful to reduce the size of stashed data.
It supports:
for the time being it supports tar, tar.gz, tar.bz2, and tar.xz. We can add more types later, only if needed.

Note:
This PR is based on #6743 and has to be reviewed after merging that one.

@khsrali
Copy link
Contributor Author

khsrali commented Feb 6, 2025

@agoscinski & @unkcpz , please hang on for review. Thought, you can have a brief look ;)

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 95.04950% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.27%. Comparing base (d2fbf21) to head (1c682b0).

Files with missing lines Patch % Lines
src/aiida/transports/transport.py 93.11% 4 Missing ⚠️
src/aiida/transports/plugins/ssh_async.py 93.19% 3 Missing ⚠️
src/aiida/engine/daemon/execmanager.py 95.35% 2 Missing ⚠️
src/aiida/orm/nodes/data/remote/stash/compress.py 97.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6746      +/-   ##
==========================================
+ Coverage   78.13%   78.27%   +0.15%     
==========================================
  Files         564      565       +1     
  Lines       42526    42700     +174     
==========================================
+ Hits        33222    33419     +197     
+ Misses       9304     9281      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khsrali khsrali force-pushed the stashing/more-types branch from 6459b8b to 5473613 Compare February 10, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant