-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid black sphere in structure viewer #637
Avoid black sphere in structure viewer #637
Conversation
08b4235
to
73e7013
Compare
The failed test is related to the query of the Crystallography Open Database, thus it is not related to this PR. |
Just wondering, is this a bug that should be reported upstream? I.e. is this an nglview problem? |
I am not sure if it is a bug or not. The problem is that we call the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #637 +/- ##
==========================================
- Coverage 83.50% 83.43% -0.07%
==========================================
Files 17 17
Lines 3546 3550 +4
==========================================
+ Hits 2961 2962 +1
- Misses 585 588 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a particularly pretty workaround, but if it works let's ship it :-)
Fix #633 .
In the case of a structure with only one atom, the structure viewer shows a black sphere. As shown below:
This could be because of the overlap between the atoms and the control of the viewer. This PR implements a quick solution by shifting the center of the control in z direction by 1. Now the viewer shows: