WIP: Video Controls #129
Draft
WIP: Video Controls #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 27, 2021 18:17
|
I can take care of the UI stuff. I already have a general idea of how I'd want it to look. |
ahodesuka
force-pushed
the
master
branch
4 times, most recently
from
b47e09e
to
2eb22dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought I would start implementing #120, So far there are no GUI controls, but these are the actual functions needed for Play/Pause, Getting time, and Setting time. Unfortunately I do not know the first thing about GTK, nor do I know where to start. but I hope this will help make Dev's job a little bit easier.
Play/Pause and time seeking works fine, but it really should be set to not work with GIFs, Playbin should take care of it, so it shouldn't cause bugs, but it would probably be best not to tempt fate.
Time seeking, and current time is currently done with percentages and nanoseconds, Im hoping this will make implementing the time/seek bar (if this is the route dev want's to go) a little bit easier, but reporting time isn't implemented yet (because I forgot, sorry), unless you want it in nanoseconds.
but using GST_FORMAT_TIME + GST_TIME_ARGS (ie. https://gstreamer.freedesktop.org/documentation/application-development/advanced/queryevents.html?gi-language=cpp) will be an easy implement.
I hope this helps the dev a little bit, Love the app.