REST feature layer extractor

[jacobdadams]

Adding a new extractor to load data from a feature layer in a REST map or feature service endpoint.

[codecov]

Codecov Report

Patch coverage: 99.25% and project coverage change: +1.09% 🎉

Comparison is base (8cfe1e9) 90.75% compared to head (5230fa3) 91.85%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   90.75%   91.85%   +1.09%     
==========================================
  Files           7        7              
  Lines         898     1031     +133     
  Branches      128      146      +18     
==========================================
+ Hits          815      947     +132     
  Misses         74       74              
- Partials        9       10       +1     

Files Changed	Coverage Δ
src/palletjack/extract.py	92.14% <99.22%> (+4.52%)	⬆️
src/palletjack/utils.py	94.84% <100.00%> (+0.06%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[steveoh]

this looks really useful. nice work.

[steveoh]

these are some nice improvements. thanks for doing those.

I wonder, since you are using so many properties of the json response, that it might be best to create a class to represent that object that takes the response dictionary as a constructor and hydrates all the fields you are interested in. you could have a private method that safely pulls values out of the dictionary to set properties and some instance methods that return true or false if the service supports what it needs. yada yada. what do you think?

[jacobdadams]

Ok, I think I've addressed all the different ideas and suggestions (minus creating a properties class...). Do you guys know of a non-OBJECTID service I can test the arbitrarily-named object id stuff against?

[stdavis]

Do you guys know of a non-OBJECTID service I can test the arbitrarily-named object id stuff against?

Here's one that I just put up. Let me know when you are done testing so that I can clean it up. I just download the dataset as a shapefile and then re-uploaded it.

https://services1.arcgis.com/99lidPhWCzftIe9K/ArcGIS/rest/services/Utah_County_Boundaries_TEST/FeatureServer/0

[jacobdadams]

Do you guys know of a non-OBJECTID service I can test the arbitrarily-named object id stuff against?

Here's one that I just put up. Let me know when you are done testing so that I can clean it up. I just download the dataset as a shapefile and then re-uploaded it.

https://services1.arcgis.com/99lidPhWCzftIe9K/ArcGIS/rest/services/Utah_County_Boundaries_TEST/FeatureServer/0

Ok, duh, I could have done that :) But thank you! It works like it should.

[steveoh]

Is authenticated access to private layers on the radar?

[jacobdadams]

Is authenticated access to private layers on the radar?

I hadn't thought about that, but that would be a good idea. I'll add it to the list while I'm rethinking/refactoring.

[jacobdadams]

Ok, I think this is finally ready. I added access to the retry values as global variables that can be set by the client programs in case the default time/retries are not enough for a given application.

[jacobdadams]

@stdavis and @steveoh, I'd love a final look at this and any last thoughts you've got.

[steveoh]

looks great. a few comments for polish.