fix styles and scrolling + pin some dependencies #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix build errors
|
|
agoose77
force-pushed
the
feat-mime-renderer
branch
from
0ce22a0 to
8bff032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@agoose77 looks like the "borked" styles and scrolling are cured by changing a couple CSS classes in
src/mime.tsx.Beyond this, I was trying to build starting from the main branch
yarn.lockand it was pretty much impossible. It seems the issue is a partial upgrade to@jupyterlab/*v3.6 caused by the introduction of@jupyterlab/markdownviewer. Hence the version pinning you see in mypackage.jsonwhich leads to a very smallyarn.lockdiff relative to the main branch.I would be happy to open a separate PR to pursue a v3.6 upgrade -- I mean, I suppose it should be done a bit carefully and independently of the feature you're trying to add here. It would also benefit my PR jupyter-book#115 as I could eliminate the nasty hack in
src/MySTMarkdownCell.tsx.