feat: add CLI support for Agent Hub #82

matewolf · 2025-04-02T13:48:12Z

No description provided.

paralta · 2025-04-03T15:54:34Z

@matewolf As discussed, I think we could improve the PR with the following suggestions:

Keep all API code under the /api folder by moving /hub/api to /api/hub/
Review if the proto messages that already exist in api/core can be reused by the hub like Locator, Category (category has been deprecated in favour of Skill) and Agent
Keep options for each command inside the corresponding command folder

Signed-off-by: matewolf <[email protected]>

Signed-off-by: Zsolt Rappi <[email protected]>

Signed-off-by: matewolf <[email protected]>

paralta · 2025-04-07T08:15:52Z

api/hub/buf.gen.yaml

+plugins:
+  - remote: buf.build/grpc/go:v1.5.1
+    out: .
+    opt: paths=source_relative
+  - remote: buf.build/protocolbuffers/go:v1.36.5
+    out: .
+    opt: paths=source_relative


here you are using the same plugins that we use for the core/store/routing APIs, so we could generate hub code with the same api/buf.gen.yaml file. this would also avoid simplify the changes in Taskfile.yml

I wouldn't like to use the same buf file and integrate deps:api:gen task because running this task would need a permission to reach the private hub repo. Maybe it is possible to exclude some module from buf generate command.

paralta · 2025-04-07T08:16:38Z

Taskfile.yml

@@ -39,6 +39,8 @@ vars:
  GOLANGCI_LINT_BIN: '{{ .BIN_DIR }}/golangci-lint-{{.GOLANGCI_LINT_VERSION}}'
  LICENSEI_VERSION: '0.9.0'
  LICENSEI_BIN: '{{ .BIN_DIR }}/licensei-{{.LICENSEI_VERSION}}'
+  HUB_API_VERSION: 'main'
+  HUB_REPO_URL: 'https://github.com/cisco-eti/phoenix-saas-be.git'


should we keep this reference to an internal repo in the open repo? the git clone below will fail for users without access

paralta · 2025-04-07T08:47:05Z

cli/cmd/root.go

-		unpublish.Command,
+		publish.NewCommand(baseOption),
+		list.NewCommand(baseOption),
+		unpublish.NewCommand(baseOption),
 		network.Command,


this new command needs to be refactored as well

paralta · 2025-04-07T08:50:52Z

cli/cli.go

@@ -17,7 +16,6 @@ func main() {
 	ctx, cancel := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGHUP, syscall.SIGTERM)

 	if err := cmd.Run(ctx); err != nil {


was this print removed by mistake?

paralta · 2025-04-07T08:53:07Z

cli/cmd/build/build.go

 This command handles the build process for agent data models
 from source code. It generates a JSON object that 
 describes an agent and satisfies the **Open Agent Schema Framework** specification.

 Usage examples:

-1. When build config is present under the agent source code:


let's keep the formatting here, since the same numbered formatting is used in the push and pull commands

paralta · 2025-04-07T09:03:56Z

cli/cmd/list/info/info.go

+	# List summary about our published data.
+   	dir list info
 	
-2. List summary about published data across the network:
-
+	# List summary about published data by a specific peer.
+   	dir list info --peer <peer-id>
+	
+	# List summary about published data by the whole network.
+	# NOTE: This starts a DHT walk, so it may take a while.
+	# NOTE: Results are not guaranteed to be complete and up-to-date.


there might have been a merge conflict issue here, please check

matewolf force-pushed the hub-cli branch 2 times, most recently from 6247ab4 to 8b99231 Compare April 3, 2025 14:18

paralta changed the title ~~Add CLI support for Agent Hub~~ feat: add CLI support for Agent Hub Apr 3, 2025

matewolf force-pushed the hub-cli branch 2 times, most recently from be296f0 to fcd0ecd Compare April 3, 2025 14:43

matewolf force-pushed the hub-cli branch from 5b76f4b to 94724c3 Compare April 4, 2025 12:37

matewolf and others added 22 commits April 4, 2025 18:13

Add login command

29c55d8

Signed-off-by: matewolf <[email protected]>

Add logout command

2c8468e

Signed-off-by: matewolf <[email protected]>

Add logout command

56bd7ec

Signed-off-by: matewolf <[email protected]>

Add push and pull agent command

8bb4c4c

Signed-off-by: matewolf <[email protected]>

refactor options and add new auth config

72c990a

Signed-off-by: matewolf <[email protected]>

add authorization for pull command

59ca2a3

Signed-off-by: matewolf <[email protected]>

add hub api protos

88586a8

Signed-off-by: matewolf <[email protected]>

resolve merge conflicts

e4b88bd

Signed-off-by: matewolf <[email protected]>

refactor options in cli

2d2b47b

Signed-off-by: matewolf <[email protected]>

change hub backend address on push/pull

1b6e62a

Signed-off-by: matewolf <[email protected]>

replace cmd context with background context

fd96e57

Signed-off-by: matewolf <[email protected]>

sign-off commits

45d6139

Signed-off-by: matewolf <[email protected]>

move hub api from /hub/api to /api/hub

9c4127c

Signed-off-by: matewolf <[email protected]>

delete empty files

7e03fdb

Signed-off-by: matewolf <[email protected]>

add tls to the grpc client

7f472be

Signed-off-by: matewolf <[email protected]>

push move api stubs

6b1eac2

Signed-off-by: matewolf <[email protected]>

fix: hub pull ID parse

d18a1f1

Signed-off-by: Zsolt Rappi <[email protected]>

fix linter errors

7ed5b67

Signed-off-by: matewolf <[email protected]>

fix task api:gen

673768e

Signed-off-by: matewolf <[email protected]>

fix format

6da072f

Signed-off-by: matewolf <[email protected]>

fix linter errors

97a11a7

Signed-off-by: matewolf <[email protected]>

rebase to main

db6fb79

Signed-off-by: matewolf <[email protected]>

matewolf force-pushed the hub-cli branch from 1c35845 to db6fb79 Compare April 4, 2025 16:22

reorder imports

5dd4f54

Signed-off-by: matewolf <[email protected]>

matewolf marked this pull request as ready for review April 4, 2025 16:23

matewolf requested a review from a team as a code owner April 4, 2025 16:23

matewolf added 3 commits April 5, 2025 01:34

rename secret to session, always fetch the config

d3db201

Signed-off-by: matewolf <[email protected]>

add tenant support

1a4406f

Signed-off-by: matewolf <[email protected]>

move options close to commands

6a5c5df

Signed-off-by: matewolf <[email protected]>

paralta reviewed Apr 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add CLI support for Agent Hub #82

feat: add CLI support for Agent Hub #82

matewolf commented Apr 2, 2025

paralta commented Apr 3, 2025 •

edited

Loading

paralta Apr 7, 2025

matewolf Apr 7, 2025 •

edited

Loading

paralta Apr 7, 2025 •

edited

Loading

paralta Apr 7, 2025

paralta Apr 7, 2025

paralta Apr 7, 2025

paralta Apr 7, 2025

		@@ -17,7 +16,6 @@ func main() {
		ctx, cancel := signal.NotifyContext(context.Background(), os.Interrupt, syscall.SIGHUP, syscall.SIGTERM)

		if err := cmd.Run(ctx); err != nil {

feat: add CLI support for Agent Hub #82

Are you sure you want to change the base?

feat: add CLI support for Agent Hub #82

Conversation

matewolf commented Apr 2, 2025

paralta commented Apr 3, 2025 • edited Loading

paralta Apr 7, 2025

Choose a reason for hiding this comment

matewolf Apr 7, 2025 • edited Loading

Choose a reason for hiding this comment

paralta Apr 7, 2025 • edited Loading

Choose a reason for hiding this comment

paralta Apr 7, 2025

Choose a reason for hiding this comment

paralta Apr 7, 2025

Choose a reason for hiding this comment

paralta Apr 7, 2025

Choose a reason for hiding this comment

paralta Apr 7, 2025

Choose a reason for hiding this comment

paralta commented Apr 3, 2025 •

edited

Loading

matewolf Apr 7, 2025 •

edited

Loading

paralta Apr 7, 2025 •

edited

Loading