Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppot for geoipasnum and geoiporg #6

Closed
wants to merge 3 commits into from
Closed

Suppot for geoipasnum and geoiporg #6

wants to merge 3 commits into from

Conversation

devteam4509
Copy link

No description provided.

@msva
Copy link
Contributor

msva commented Jul 22, 2016

@akshay2013 @akshayodesk can you rebase your work on top of current HEAD, amend unneded "delete" commit, and force-push your PullReq? I think, there will be more chances @agladysh to accept it then.

@devteam4509
Copy link
Author

Ok done
Please check

Thanks

On Sat, Jul 23, 2016 at 12:03 AM, Vadim A. Misbakh-Soloviov <
[email protected]> wrote:

@akshay2013 https://github.com/akshay2013 can you rebase your work on
top of current HEAD, amend unneded "delete" commit, and force-push your
PullReq? I think, there will be more chances @agladysh
https://github.com/agladysh to accept it then.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJSaZi5PpM2UZTtq6DSl4ko9Yqq9dwXKks5qYQ0WgaJpZM4DQ46J
.

@msva
Copy link
Contributor

msva commented Jul 23, 2016

Actually, "delete" commit (and broken initial) is still in place, and, moreover, github still says your branch conflicting with current master.

If you have no objections, I would try to re-do your changes in single commit and will post additional PR when @agladysh will accept that one I already posted :)

@devteam4509
Copy link
Author

Thiss is the new pul request -->
#17

On Sat, Jul 23, 2016 at 7:21 PM, Vadim A. Misbakh-Soloviov <
[email protected]> wrote:

Actually, "delete" commit (and broken initial) is still in place, and,
moreover, github still says your branch conflicting with current master.

If you have no objections, I would try to re-do your changes in single
commit and will post additional PR when @agladysh
https://github.com/agladysh will accept that one I already posted :)


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#6 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJSaZma231Cjkj1MU6Rrk4BtPA9otVSZks5qYhxHgaJpZM4DQ46J
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants