Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit of working asnum.c, to perform ASN lookups #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robison
Copy link

@robison robison commented Dec 15, 2015

This has been tested empirically and found to work for name, addr, and ipnum lookups. Still working on the actual test cases; would appreciate any feedback.

@agladysh
Copy link
Owner

Thank you for your contribution! Please provide basic autotests and add yourself to the AUTHORS file so I can merge this.

On 15 дек. 2015 г., at 22:09, Robison Jacka [email protected] wrote:

This has been tested empirically and found to work for name, addr, and ipnum lookups. Still working on the actual test cases; would appreciate any feedback.

You can view, comment on, or merge this pull request online at:

#13

Commit Summary

Commit of working asnum.c, to perform ASN lookups
File Changes

A src/asnum.c (228)
Patch Links:

https://github.com/agladysh/lua-geoip/pull/13.patch
https://github.com/agladysh/lua-geoip/pull/13.diff

Reply to this email directly or view it on GitHub.

@robison
Copy link
Author

robison commented Jan 13, 2016

This should be finished now. Found a dumb memory leak on my part, and finally squashed it. Also finished the tests & profiling for geodb.asnum. Please take a look, and let me know if you see anything that needs updating/fixing. Thanks!

@agladysh
Copy link
Owner

Thank you for your pull request. Please see my questions.

@msva
Copy link
Contributor

msva commented Jul 22, 2016

@robison ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants