Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore repos folder #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ignore repos folder #13

wants to merge 1 commit into from

Conversation

listx
Copy link

@listx listx commented Feb 25, 2022

This helps keep things clean when we use zcomet as a git submodule,
because populating the "repos" folder does not result in git thinking that
the zcomet repo itself has become dirty.

This helps keep things clean when we use zcomet as a git submodule,
because populating the "repos" folder does not result in git thinking that
the zcomet repo itself has become dirty.
@agkozak
Copy link
Owner

agkozak commented Mar 4, 2022

Thanks for your proposal, and sorry it has taken me a while to get back to you.

Are you assuming that the user has employed zstyle to specify a custom plugin directory inside the zcomet submodule? If they don't do that, the plugins just end up in ~/.zcomet/repos or $ZDOTDIR/.zcomet/repos, which solves the problem in another way.

@agkozak agkozak self-assigned this Mar 4, 2022
@listx
Copy link
Author

listx commented Mar 5, 2022

Thanks for your proposal, and sorry it has taken me a while to get back to you.

No problem.

Are you assuming that the user has employed zstyle to specify a custom plugin directory inside the zcomet submodule?

I did not know about this, so no.

If they don't do that, the plugins just end up in ~/.zcomet/repos or $ZDOTDIR/.zcomet/repos, which solves the problem in another way.

My setup may be an edge case. My ZDOTDIR points to ~/.zsh (the default), but ~/.zsh itself is a symlink to a git dotfiles repo that I have. Specifically in my case the symlinks are:

~/.zsh -> ~/syscfg/zsh
~/.zcomet -> ~/syscfg/zsh/zcomet

So what happens is that the repos get populated under ~/syscfg/zsh/zcomet/repos. To recap, syscfg is my dotfiles folder. The interesting twist here is that ~/syscfg/zsh/zcomet is a submodule, so now the repos folder is showing up as an untracked folder in the zcomet submodule folder.

I guess I can simply move around the folders/symlinks I have set up so that this PR is unnecessary. If you agree, feel free to close, thanks.

listx added a commit to listx/syscfg that referenced this pull request Mar 22, 2022
No functional change. This just makes it so that the ~/.zcomet/repos
folder no longer resides inside the upstream zcomet code (git
submodule). Workaround for agkozak/zcomet#13.
listx added a commit to listx/syscfg that referenced this pull request Mar 22, 2022
No functional change. This just makes it so that the ~/.zcomet/repos
folder no longer resides inside the upstream zcomet code (git
submodule). Workaround for agkozak/zcomet#13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants