Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smult #22

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

Smult #22

wants to merge 39 commits into from

Conversation

StanislauParuchnik
Copy link
Collaborator

@StanislauParuchnik StanislauParuchnik commented Jul 18, 2021

Поддержка предвычислений малых кратных.

Todo:

  • расчет малых кратных в аффинных и якобиевых координатах, с помощью полиномов деления и метода "+2P";
  • печать предвычисленных малых кратных базовой точки для кривых bign;
  • таблицы предвычисленных малых кратных базовой точки для кривых bign;
  • регулярный (SAFE) оконный метод вычисления кратной точки;
  • приведение к нечетной кратности в оконном методе через (q-d), если d - четное;
  • использование предвычислений в нерегулярном (FAST) NAF методе вычисления кратной точки;
  • тесты и бенчмарки арифметики и алгоритмов bign/bake;
  • корректные метрики при замерах производительности в бенчмарках;
  • поддержка алгоритма ecAddMulA вычисления суммы кратных точек;
  • безопасная работа со стеком, корректный расчет размера стека;
  • поддержка якобиевых координат для online-предвычислений;
  • зачистка кода от временных/излишних/тестовых изменений.
  • использовать complete formulas для последнего сложения

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #22 (b019c8d) into master (116fc29) will decrease coverage by 32.76%.
The diff coverage is 68.37%.

❗ Current head b019c8d differs from pull request most recent head 5acf382. Consider uploading reports for the commit 5acf382 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
- Coverage   85.69%   52.93%   -32.77%     
===========================================
  Files          66       75        +9     
  Lines       11916    12901      +985     
===========================================
- Hits        10212     6829     -3383     
- Misses       1704     6072     +4368     
Impacted Files Coverage Δ
src/crypto/bign/bign_params.c 92.43% <ø> (ø)
src/math/ecp/ecp_smult.c 1.30% <1.30%> (ø)
src/math/ec2.c 77.41% <20.00%> (-2.49%) ⬇️
src/crypto/bign/bign_misc.c 38.35% <38.35%> (ø)
src/core/util.c 49.31% <50.00%> (-39.73%) ⬇️
src/math/ecp/ecp_a.c 53.48% <53.48%> (ø)
src/crypto/bign/bign_keyt.c 70.73% <70.73%> (ø)
src/crypto/bign/bign_keys.c 73.83% <73.83%> (ø)
src/crypto/bign/bign_sign.c 78.68% <78.68%> (ø)
src/crypto/bign/bign_ibs.c 79.62% <79.62%> (ø)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116fc29...5acf382. Read the comment docs.

Copy link
Collaborator Author

@StanislauParuchnik StanislauParuchnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants