Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create module-1about.md #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create module-1about.md #5

wants to merge 1 commit into from

Conversation

sonic536
Copy link

Needs checking :D

@ccannon94 ccannon94 requested review from ccannon94 and removed request for ccannon94 October 31, 2017 23:07
ccannon94
ccannon94 requested changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@ccannon94 ccannon94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you're here Tarek! There's just a small issue with your file name. If you'd like this merged, please follow the path explained in Module 1 (the youtube video probably has the best explanation). It should be github-training/submissions/sonic536/about.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccannon94 ccannon94 ccannon94 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sonic536 @ccannon94