fix downloading logs #2990
Open
fix downloading logs #2990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
reviewed
Jan 8, 2026
Contributor
imobachgs
left a comment
imobachgs
left a comment
There was a problem hiding this comment.
In general, it looks good. I guess we still need to fix the UI.
| pub async fn store(&self, path: &Path) -> Result<PathBuf, ManagerHTTPClientError> { | ||
| // 1) response with logs | ||
| let response = self.client.get_raw("/manager/logs/store").await?; | ||
| let response = self.client.get_raw("/v2/private/download_logs").await?; |
Contributor
There was a problem hiding this comment.
I am not sure whether this should be part of the private API. However, until we take a decision, it is good to keep it in the private part.
Additionally, I would name it as /v2/private/logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
download logs via CLI does not work and as result also copy of logs at the end of installation does not work.
Solution
Use the same code as in manager web interface, just move it to internal part and adapt client to use it.
Testing