Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ISetFilter’s valueFormatter typesafe #6391

Open
wants to merge 1 commit into
base: latest
Choose a base branch
from
+1 −1
Open

Make ISetFilter’s valueFormatter typesafe #6391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion grid-community-modules/core/src/ts/interfaces/iSetFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ export interface ISetFilterParams<TData = any, V = string> extends IProvidedFilt
* If a Key Creator is provided (see `keyCreator`), this must also be provided,
* unless `convertValuesToStrings` is `true`
*/
valueFormatter?: (params: ValueFormatterParams) => string;
valueFormatter?: (params: ValueFormatterParams<TData, V>) => string;
/**
* Function to return a string key for a value. This is required when the filter values are complex objects,
* or when `treeList = true` and the column is a group column with Tree Data or Grouping enabled.
Expand Down