chore: fix build #130
Merged
chore: fix build #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes build issues and enables CI using the Envoy builder Docker images. It updates the CI documentation and introduces two new GitHub workflow files for building MetaProtocol and API components.
- Updated CI documentation in ci/README.md to detail usage of various Envoy Docker images.
- Added workflows (.github/workflows/build_meta_proticol_proxy.yml and .github/workflows/build_api.yml) to run builds via GitHub Actions.
- Configured environment variables and build steps for both MetaProtocol and API CI jobs.
Reviewed Changes
Copilot reviewed 50 out of 67 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| ci/README.md | New documentation on using CI Docker images and detailed build instructions. |
| .github/workflows/build_meta_proticol_proxy.yml | New workflow for building MetaProtocolProxy with long timeout and Docker steps. |
| .github/workflows/build_api.yml | New workflow for building the API with similar configurations as the MetaProtocol workflow. |
Files not reviewed (17)
- .bazelversion: Language not supported
- .github/workflows/buildci.yml: Language not supported
- Makefile: Language not supported
- WORKSPACE: Language not supported
- ci/Dockerfile-envoy: Language not supported
- ci/Dockerfile-envoy-windows: Language not supported
- ci/WORKSPACE.filter.example: Language not supported
- ci/api_mirror.sh: Language not supported
- ci/build_setup.sh: Language not supported
- ci/check_and_fix_format.sh: Language not supported
- ci/ci_api.sh: Language not supported
- ci/ci_dev.sh: Language not supported
- ci/create_release_branch.sh: Language not supported
- ci/docker-entrypoint.bat: Language not supported
- ci/docker-entrypoint.sh: Language not supported
- ci/docker_ci.sh: Language not supported
- ci/docker_rebuild_google-vrp.sh: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/build_meta_proticol_proxy.yml:30
- The variable 'protocal' appears misspelled; consider changing it to 'protocol' to enhance clarity and consistency.
LOG_PATH: /tmp/test_logs/${{ matrix.protocal }}.log
.github/workflows/build_api.yml:30
- The variable 'protocal' appears misspelled here as well; renaming it to 'protocol' would improve readability and reduce confusion.
LOG_PATH: /tmp/test_logs/${{ matrix.protocal }}.log
smwyzi
reviewed
Mar 28, 2025
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Merged
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Chenrujie-85
pushed a commit
to Chenrujie-85/meta-protocol-proxy
that referenced
this pull request
Mar 29, 2025
…-proxy into develop * 'master' of https://github.com/aeraki-mesh/meta-protocol-proxy: chore: fix build (aeraki-mesh#130) # Conflicts: # WORKSPACE # clang.bazelrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #128
Also enable CI using the Envoy builder docker.