Update ImgixTransformedImageModel.php #294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Myeah, seems like some behaviour has changed somewhere, this issue has popped up from time to time, and I know that it used to work. What type of Asset and Imgix source are you seeing this on? Seems like I'm even getting different results on different configurations. Are you using signed URL's? |
|
Fixed this in 2.4.0, turns out the paths doesn't need any encoding at all anymore. Also, check out Imager X. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some paths and filenames containing non-ascii chars such as "åäö" got incorrect encoded urls. This line fixes that. Although, since I'm not too familiar with php - it might be concidered a bad solution.