Add podcast permissions for non-admin users #3933
Open
+12
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes advplyr#1258 Add user permissions for uploading podcasts and downloading episodes. * Update `client/components/app/SideRail.vue` to check for `userCanUpload` instead of `userIsAdminOrUp` for podcast search and download queue links. * Add `getUserCanUpload` getter in `client/store/user.js` to check the new `upload` permission. * Update `server/controllers/PodcastController.js` to allow users with the `upload` permission to create and download podcasts. * Add `upload` permission for non-admin users in `server/models/User.js`. * Add `upload` permission toggle switch in `client/components/modals/AccountModal.vue`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/advplyr/audiobookshelf/issues/1258?shareId=XXXX-XXXX-XXXX-XXXX).
advplyr
reviewed
Feb 4, 2025
| @@ -169,7 +169,7 @@ class User extends Model { | |||
| download: true, | |||
| update: type === 'root' || type === 'admin', | |||
| delete: type === 'root', | |||
| upload: type === 'root' || type === 'admin', | |||
| upload: type === 'root' || type === 'admin' || type === 'user', | |||
There was a problem hiding this comment.
I don't think upload should be default for users
| @@ -477,7 +477,7 @@ class User extends Model { | |||
| * User data for clients | |||
| * Emitted on socket events user_online, user_offline and user_stream_update | |||
| * | |||
| * @param {import('../objects/PlaybackSession')[]} sessions | |||
| * @param {import('../objects/PlaybackSession')} sessions | |||
There was a problem hiding this comment.
Is this not an array of sessions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1258
Add user permissions for uploading podcasts and downloading episodes.
client/components/app/SideRail.vueto check foruserCanUploadinstead ofuserIsAdminOrUpfor podcast search and download queue links.getUserCanUploadgetter inclient/store/user.jsto check the newuploadpermission.server/controllers/PodcastController.jsto allow users with theuploadpermission to create and download podcasts.uploadpermission for non-admin users inserver/models/User.js.uploadpermission toggle switch inclient/components/modals/AccountModal.vue.For more details, open the Copilot Workspace session.